[2770] Fix a warning in the console when using handle outside a react…

…flow node Bug: #2770 Signed-off-by: Florian ROUËNÉ <[email protected]>
eclipse-sirius · Oct 17, 2024 · 4c102e9 · 4c102e9
1 parent 75f2a22
commit 4c102e9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/DiagramRenderer.types.ts b/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/DiagramRenderer.types.ts
@@ -54,6 +54,7 @@ export interface NodeData extends Record<string, unknown> {
   isDropNodeTarget: boolean;
   isDropNodeCandidate: boolean;
   isHovered: boolean;
+  isFake?: boolean;
 }
 
 export enum BorderNodePosition {

diff --git a/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/layout/layout.tsx b/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/layout/layout.tsx
@@ -137,7 +137,7 @@ export const prepareLayoutArea = (
         const element = createElement(FreeFormNode, {
           ...freeFormNodeProps,
           id: node.id,
-          data: node.data,
+          data: { ...node.data, isFake: true },
           key: `${node.id}-${index}`,
         });
         children.push(element);
@@ -147,7 +147,7 @@ export const prepareLayoutArea = (
           ...emptyNodeProps,
           type: 'listNode',
           id: node.id,
-          data: node.data,
+          data: { ...node.data, isFake: true },
         };
 
         const element = createElement(ListNode, {

diff --git a/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/node/FreeFormNode.tsx b/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/node/FreeFormNode.tsx
@@ -155,8 +155,10 @@ export const FreeFormNode: NodeComponentsMap['freeFormNode'] = memo(
             />
           ) : null}
           {selected ? <ConnectionCreationHandles nodeId={id} /> : null}
-          <ConnectionTargetHandle nodeId={id} nodeDescription={data.nodeDescription} isHovered={data.isHovered} />
-          <ConnectionHandles connectionHandles={data.connectionHandles} />
+          {!data.isFake && (
+            <ConnectionTargetHandle nodeId={id} nodeDescription={data.nodeDescription} isHovered={data.isHovered} />
+          )}
+          {!data.isFake && <ConnectionHandles connectionHandles={data.connectionHandles} />}
         </div>
         {data.outsideLabels.BOTTOM_MIDDLE && (
           <Label diagramElementId={id} label={data.outsideLabels.BOTTOM_MIDDLE} faded={data.faded} />

diff --git a/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/node/ListNode.tsx b/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/node/ListNode.tsx
@@ -90,8 +90,10 @@ export const ListNode: NodeComponentsMap['listNode'] = memo(
             />
           ) : null}
           {selected ? <ConnectionCreationHandles nodeId={id} /> : null}
-          <ConnectionTargetHandle nodeId={id} nodeDescription={data.nodeDescription} isHovered={data.isHovered} />
-          <ConnectionHandles connectionHandles={data.connectionHandles} />
+          {!data.isFake && (
+            <ConnectionTargetHandle nodeId={id} nodeDescription={data.nodeDescription} isHovered={data.isHovered} />
+          )}
+          {!data.isFake && <ConnectionHandles connectionHandles={data.connectionHandles} />}
         </div>
       </>
     );