Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for build with updated bundle versions #3899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fipro78
Copy link
Contributor

@fipro78 fipro78 commented May 31, 2024

This adds a test that

  • first builds the pde-automatic-manifest demo project
  • then updates the version of the whole demo using the tycho-versions-plugin
  • then checks if the build succeeded
  • finally reverts the version update

Copy link

github-actions bot commented May 31, 2024

Test Results

  594 files  ±0    594 suites  ±0   3h 54m 41s ⏱️ - 18m 0s
  426 tests +1    419 ✅ +1   7 💤 ±0  0 ❌ ±0 
1 278 runs  +3  1 256 ✅ +3  22 💤 ±0  0 ❌ ±0 

Results for commit ccb3325. ± Comparison against base commit 8574107.

♻️ This comment has been updated with latest results.

Verifier verifier = runDemo("pde-automatic-manifest");

// now update the version
Verifier updateVerifier = super.getVerifier("../../demo/pde-automatic-manifest", true, true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need a new verifier here just reuse the one from above.

@laeubi
Copy link
Member

laeubi commented Jun 1, 2024

finally reverts the version update

As you should get a copy for the test i don't think this is required?

@laeubi
Copy link
Member

laeubi commented Jun 6, 2024

@fipro78 for some reason this now has compile errors :-\

@fipro78
Copy link
Contributor Author

fipro78 commented Jun 6, 2024

It somehow has changed the import statement. Can't explain why, but that seems to be the reason.

@laeubi
Copy link
Member

laeubi commented Jun 8, 2024

@fipro78 now all test succeed... can you maybe give some manual instructions and where /when you would it expect to fail with the given example? I'll then take a look at it.

@fipro78
Copy link
Contributor Author

fipro78 commented Jun 8, 2024

I followed my tutorial after I updated to the automatic manifest generation. And everytime I change the version back and forth the issue appears.

https://github.com/fipro78/e4-cookbook-basic-recipe/blob/master/tutorials/Eclipse_RCP_Cookbook_p2.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants