Improve throughput performance #3 (rx buffer focus) #749
+185
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-roland
changed the title
|
PR missing one of the required labels: {'internal', 'new feature', 'bug', 'enhancement', 'dependencies', 'breaking-change', 'documentation'} |
sashacmc
reviewed
Oct 18, 2024
| // Check if user or defragment buffer took ownership of buffer | ||
| if (!_z_zbuf_is_last_ref(&ztm->_zbuf)) { | ||
| // Allocate a new buffer | ||
| _z_zbuf_t new_zbuf = _z_zbuf_make(Z_BATCH_MULTICAST_SIZE); |
There was a problem hiding this comment.
I don't know the raweth very well, but should we use Z_BATCH_MULTICAST_SIZE there?
There was a problem hiding this comment.
Yes because raweth is a mix between a link and a multicast transport so it should behave as closely as possible as such.
sashacmc
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve rx performance we need to reduce the amount of copies that are made. By using a refcount and by allocating dynamically the rx buffers we can avoid copies at the cost of memory allocation, only in the case where data is processed out of context [note: that is the case of query replies in latest consolidation mode].