-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove climetlab to be replaced by earthkit #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Am I right that this is not backwards compatible with a climetlab input, because of the changes to datetime?
(it doesn't need to be compatible, just for my own understanding)
@gmertes At the moment, yes it is not backwards compatible. It might be possible to make it so |
- ekd instead of earthkit.data - Use 'valid_time' instead of 'base_time'
cba7014
to
d264d45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8 +/- ##
========================================
Coverage 85.50% 85.50%
========================================
Files 2 2
Lines 69 69
========================================
Hits 59 59
Misses 10 10 ☔ View full report in Codecov by Sentry. |
pyproject.toml
Closes #7