Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove climetlab to be replaced by earthkit #8

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Sep 4, 2024

  • Replaces climetlab with earthkit
  • Added to CHANGELOG
  • Adjusted pyproject.toml

Closes #7

@HCookie HCookie self-assigned this Sep 4, 2024
@FussyDuck
Copy link

FussyDuck commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@gmertes gmertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Am I right that this is not backwards compatible with a climetlab input, because of the changes to datetime?

(it doesn't need to be compatible, just for my own understanding)

src/anemoi/inference/runner.py Outdated Show resolved Hide resolved
src/anemoi/inference/runner.py Outdated Show resolved Hide resolved
@HCookie
Copy link
Member Author

HCookie commented Sep 4, 2024

@gmertes At the moment, yes it is not backwards compatible. It might be possible to make it so

@HCookie HCookie marked this pull request as ready for review September 4, 2024 15:29
- Replaces climetlab with earthkit
- ekd instead of earthkit.data
- Use 'valid_time' instead of 'base_time'
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.50%. Comparing base (48f21cd) to head (60e634f).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop       #8   +/-   ##
========================================
  Coverage    85.50%   85.50%           
========================================
  Files            2        2           
  Lines           69       69           
========================================
  Hits            59       59           
  Misses          10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmertes gmertes merged commit 24e27c8 into develop Sep 6, 2024
63 of 107 checks passed
@gmertes gmertes deleted the fix/remove-climetlab branch September 6, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace climatlab with earthkit
5 participants