Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorm实现 #3

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

gorm实现 #3

wants to merge 27 commits into from

Conversation

juniaoshaonian
Copy link
Contributor

No description provided.

Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先暂时把所有的代码都挪过去 internal。

你这里要考虑两个:

  • 用户的 producer 通过 GRPC 调用你。
  • 用户的 consumer 也通过 gRPC 调用你。

或者说,你要考虑三个东西:broker, consumer 和 producer。用户可以考虑:

  • broker 独立部署,用户借助 gRPC 或者 HTTP 接口完成生产或者消费
  • broker 和 producer 部署在生产者业务这一边,消费者通过 gRPC 或者 HTTP 接口消费
  • broker 和 consumer 部署在消费者这一边,生产者通过 gRPC 或者 HTTP 接口生产
  • 全部部署到一起,作为一个单体应用

在这之前,你可以先合并最新代码。然后把代码放进去 internal,后面再考虑通过 SDK 或者 gRPC HTTP 接口暴露出来。

Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog 这个 action 不需要

@flycash
Copy link
Contributor

flycash commented Sep 27, 2023

你这 CI 全崩了=。=

@codecov
Copy link

codecov bot commented Sep 27, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants