Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-481] Remove processor from cargo workspace #473

Merged
merged 2 commits into from
Sep 18, 2023
Merged

[ECO-481] Remove processor from cargo workspace #473

merged 2 commits into from
Sep 18, 2023

Conversation

CRBl69
Copy link
Collaborator

@CRBl69 CRBl69 commented Sep 13, 2023

This PR is intended to remove the processor from the cargo workspace to fix CI. It also reviled another problem with CI (an argument to a command that was copy pasted where it shouldn't have been) which was fixed.

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
econia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 10:54am

@vercel vercel bot temporarily deployed to Preview September 13, 2023 10:37 Inactive
@vercel vercel bot temporarily deployed to Preview September 13, 2023 10:39 Inactive
@elliottdehn
Copy link
Contributor

elliottdehn commented Sep 14, 2023

When I do this on my machine, it takes away red underlines and hints in the processor project. I consider them necessary for development in Rust. Making the processor a dependency does the same thing.

@elliottdehn elliottdehn self-requested a review September 14, 2023 16:41
Copy link
Contributor

@elliottdehn elliottdehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to do but it isn't an option to go without compiler hints and errors in IDE for me. Perhaps there's some other approach to address the issues?

@elliottdehn elliottdehn merged commit 936317b into main Sep 18, 2023
3 of 5 checks passed
@elliottdehn elliottdehn deleted the ECO-481 branch September 18, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants