-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-486][ECO-538] Add balance update support #511
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
#[derive(Clone, Debug, Queryable, Selectable, Insertable)] | ||
#[diesel(table_name = crate::schema::market_account_handles)] | ||
pub struct MarketAccountHandle { | ||
pub user: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would include a time field so that we can know when a user's accounts first became active.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included as of 5ab84ae
@@ -26,6 +26,8 @@ CREATE TRIGGER change_order_size_events_trigger | |||
AFTER INSERT ON change_order_size_events FOR EACH ROW | |||
EXECUTE PROCEDURE notify_change_order_size_event (); | |||
|
|||
CREATE VIEW api.change_order_size_events AS SELECT * FROM change_order_size_events; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update the openapi.json
in the docs.
If you would: consider changing the host name in the generated docs to use port 3001 instead of 3000. This will allow people to use the request simulator to hit their local deployment. It uses 3000 because it's using the docker internal port to generate the docs.
I didn't do this originally because I didn't want us to have to manually edit the docs but I think this is a fine exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferring API spec updates to #513
@@ -87,3 +92,6 @@ $$ LANGUAGE plpgsql; | |||
CREATE TRIGGER place_swap_order_events_trigger | |||
AFTER INSERT ON place_swap_order_events FOR EACH ROW | |||
EXECUTE PROCEDURE notify_place_swap_order_event (); | |||
|
|||
CREATE VIEW api.place_swap_order_events AS SELECT * FROM place_swap_order_events; | |||
GRANT SELECT ON api.place_swap_order_events TO web_anon; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to add these in a new migration rather than updating the existing one now that we've distributed this code to other people. They won't be able to run the migration if it's already been run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included as of 5ab84ae
MarketAccounts
table handlesMarketAccount
table entriesTo verify
Run Docker compose instructions per the docs site then see http://0.0.0.0:3001/balance_updates