Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xiplot and pyodide #46

Merged
merged 5 commits into from
Sep 16, 2023
Merged

Update xiplot and pyodide #46

merged 5 commits into from
Sep 16, 2023

Conversation

Aggrathon
Copy link
Member

This PR updates xiplot and manually triggers the lazy load of jsonschema at the same time as sklearn.
Since a new version of pyodide (with some loading speed improvements) was recently released I updated it as well.

Copy link
Collaborator

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juntyr
Copy link
Collaborator

juntyr commented Sep 15, 2023

Just a brief question - why are we now lazily loading jsonschema?

@Aggrathon
Copy link
Member Author

Just a brief question - why are we now lazily loading jsonschema?

Mostly because it is possible (and it slightly reduces the load time)

@juntyr
Copy link
Collaborator

juntyr commented Sep 15, 2023

Just a brief question - why are we now lazily loading jsonschema?

Mostly because it is possible (and it slightly reduces the load time)

Ok, that makes sense to me. Could we have a unit test to ensure that loading the xiplot library into Python doesn’t need the sklearn and jsonschema imports immediately?

@Aggrathon
Copy link
Member Author

Ok, that makes sense to me. Could we have a unit test to ensure that loading the xiplot library into Python doesn’t need the sklearn and jsonschema imports immediately?

That's a good idea! I've added asserts to the bundle script (as a last safety check) and a unit test in #47.

@Aggrathon Aggrathon merged commit 1b43bf8 into wasm Sep 16, 2023
1 check passed
@Aggrathon Aggrathon deleted the update_pyodide branch September 16, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants