tools: periodically clean up bare-metal servers #933
+155
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
reviewed
Oct 15, 2024
Comment on lines
+11
to
+12
| declare -a usedRuntimeClasses=() | ||
| declare -a unusedRuntimeClasses=() |
There was a problem hiding this comment.
I find the logic in this script hard to follow. Have you considered just filling a temp file with runtimeclasses in use, and using comm(1) to do the set difference?
| declare -a usedRuntimeClasses=() | ||
| declare -a unusedRuntimeClasses=() | ||
|
|
||
| resourcesToCheck=( |
There was a problem hiding this comment.
If we checked for an existing node installer, we could tell whether a runtime is just about to be installed.
Freax13
reviewed
Oct 16, 2024
Comment on lines
+48
to
+53
| # Delete unused binaries | ||
| path="${OPTEDGELESS}/${runtimeClass}" | ||
| if [ -d "${path}" ]; then | ||
| echo "Deleting binaries from ${OPTEDGELESS}/${runtimeClass} ..." | ||
| rm -rf "${path}" | ||
| fi |
There was a problem hiding this comment.
We also store data in /var/lib/nydus-snapshotter/.
Comment on lines
+163
to
+165
| busybox | ||
| kubectl | ||
| dasel |
There was a problem hiding this comment.
Do we need this here or is it enough to specify this in writeShellApplication?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cronjob to clean up the runtime classes on the bare-metal servers. All unused runtime classes get deleted and the containerd config is updated, and the corresponding folder in
/opt/edgelessgets deleted as well.