peer-pods: pass policy hash via userdata #941
Draft
+314
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
burgerdev
commented
Oct 18, 2024
burgerdev
commented
- Add some plumbing to forward the agent policy to remote hypervisor
- Add a policy-hash field to the agent config that's set via userdata.
- Measure the agent config into PCR10.
- The daemon config contains a bunch of hard-to-predict network config, but we should double-check whether it could be an attack vector.
- Add hash-from-agent-config as an option in the hash-verification.
burgerdev
force-pushed
the
burgerdev/user-data
branch
from
01f3c0c
to
aeacb19
Compare
burgerdev
force-pushed
the
burgerdev/user-data
branch
from
aeacb19
to
d6dd9c1
Compare
Freax13
reviewed
Oct 18, 2024
| @@ -0,0 +1,116 @@ | |||
| From 797a113c80c9fd3dfbd4d7b153d3de245c97044f Mon Sep 17 00:00:00 2001 | |||
| From: Markus Rudy <[email protected]> | |||
There was a problem hiding this comment.
Did you intentionally use a different e-mail address?
There was a problem hiding this comment.
Unintentional, that's my default and apparently I did not change it for CAA.
Comment on lines
+91
to
+95
| - {path: cfg.paths.agentConfig, optional: false}, | ||
| + {path: cfg.paths.agentConfig, optional: false, pcrIndex: toPtr(10)}, | ||
| {path: cfg.paths.daemonConfig, optional: false}, | ||
| {path: cfg.paths.aaConfig, optional: true}, | ||
| {path: cfg.paths.cdhConfig, optional: true}, |
There was a problem hiding this comment.
Have you considered measuring the other files as well?
There was a problem hiding this comment.
We're not using the three optional files (maybe we should even remove them), and the daemonConfig contains unpredictable network stuff (e.g. k8s node IP) - see PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.