Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and simplify setup #8

Merged
merged 9 commits into from
Nov 2, 2023
Merged

Fix and simplify setup #8

merged 9 commits into from
Nov 2, 2023

Conversation

wolfgangmm
Copy link
Member

  • Incorporates most of the changes/updates suggested in PR update files to match our recent docker-compose standards #7 by @chakl
  • Omits some configuration steps by parametrizing settings in docker-compose.yml. Building a single xar app is now possible without editing the Dockerfile
  • Use nginx templates. Modifying the nginx configuration is no longer required for the default setup. No more search & replace in files

Not having to fiddle with configuration files makes the process much faster, smoother and less error prone.

Copy link

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfgangmm wolfgangmm merged commit 2c8fe04 into master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants