Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: do not resolve debug info on build id mismatch #101

Open
wants to merge 2 commits into
base: stable-1.5
Choose a base branch
from
Open

Fix: do not resolve debug info on build id mismatch #101

wants to merge 2 commits into from

Commits on Dec 10, 2018

  1. Fix: do not resolve debug info on build id mismatch 

    Issue
=====
Babeltrace is showing erroneous debugging information when a trace is
read on a system that has a different version of the binary that of the
binary recording in trace.

This is due to the fact that Babeltrace currently does not confirm that
the binary(or debuglink) before resolving the debugging information.

The build ids in the trace and in the local binary must be the same to
ensure that instruction pointer addresses can be decoded.

Solution
========
Now when setting the build id, confirm that the trace build id and the
binary build id match. Once the match is confirmed, set the
`file_build_id_matches` field in the corresponding the `bin_info`
structure. This way when decoding the events, we can quickly check if
the debugging information is available for that binary.

Drawback
========
None.

Signed-off-by: Francis Deslauriers <[email protected]>
    @frdeso
    frdeso committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    1eb2d5f View commit details
    Browse the repository at this point in the history

  2. Tests: add build id mismatch testcase 

    Signed-off-by: Francis Deslauriers <[email protected]>
    @frdeso
    frdeso committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    96dad1c View commit details
    Browse the repository at this point in the history