Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playerItems) : no wool if conds not met #53

Open
wants to merge 3 commits into
base: stable
Choose a base branch
from
Open

fix(playerItems) : no wool if conds not met #53

wants to merge 3 commits into from

Conversation

Mathu-lmn
Copy link
Member

@Mathu-lmn Mathu-lmn commented Jun 23, 2024

Fix le fait de recevoir la laine blanche qui ouvre un menu vide si la game ne se relance pas

@Mathu-lmn Mathu-lmn added the bug Something isn't working label Jun 23, 2024
@Mathu-lmn Mathu-lmn requested a review from JiveOff June 23, 2024 13:43
@Mathu-lmn Mathu-lmn self-assigned this Jun 23, 2024
@@ -51,7 +51,7 @@ public static void preparePlayerForLobby(LudosPlayer player) {
public static void preparePlayerItems(LudosPlayer player) {
List<MenuItem> items = new ArrayList<>();

if(Core.get().getTeamManager().getTeams().size() > 2) {
if(Core.get().getTeamManager().getTeams().size() > 2 && Core.get().getGameManager().isAutoGameStart() && Core.get().getGameManager().getDefaultGamePluginName() != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment ça isAutoGameStart? On devrait pouvoir donner une wool si on set un jeu ne démarrant pas automatiquement

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Car si autoGameStart est false, le jeu actuel ne restart pas et donc pas de choix de teams non ?

Copy link
Member

@JiveOff JiveOff Jun 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui mais si je fais un /game load LudosArena & que le jeu ne doit pas démarrer automatiquement, les joueurs doivent pouvoir recevoir une wool

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oui j'avais pas pensé à cette situation. Soit on remove cette condition soit on mets une sorte de paramètre dans la fonction qui donne l'information si on "force" le give

Copy link
Member

@JiveOff JiveOff Jun 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense qu'il faudrait vérifier pourquoi il y a + de deux teams d'enregistré s'il n'y a aucun jeu de chargé, il faut voir si on cleanup bien les teams avant d'envoyer les joueurs sur le lobby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants