-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(playerItems) : no wool if conds not met #53
base: stable
Are you sure you want to change the base?
Conversation
@@ -51,7 +51,7 @@ public static void preparePlayerForLobby(LudosPlayer player) { | |||
public static void preparePlayerItems(LudosPlayer player) { | |||
List<MenuItem> items = new ArrayList<>(); | |||
|
|||
if(Core.get().getTeamManager().getTeams().size() > 2) { | |||
if(Core.get().getTeamManager().getTeams().size() > 2 && Core.get().getGameManager().isAutoGameStart() && Core.get().getGameManager().getDefaultGamePluginName() != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment ça isAutoGameStart? On devrait pouvoir donner une wool si on set un jeu ne démarrant pas automatiquement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Car si autoGameStart est false, le jeu actuel ne restart pas et donc pas de choix de teams non ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui mais si je fais un /game load LudosArena & que le jeu ne doit pas démarrer automatiquement, les joueurs doivent pouvoir recevoir une wool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah oui j'avais pas pensé à cette situation. Soit on remove cette condition soit on mets une sorte de paramètre dans la fonction qui donne l'information si on "force" le give
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je pense qu'il faudrait vérifier pourquoi il y a + de deux teams d'enregistré s'il n'y a aucun jeu de chargé, il faut voir si on cleanup bien les teams avant d'envoyer les joueurs sur le lobby
Fix le fait de recevoir la laine blanche qui ouvre un menu vide si la game ne se relance pas