Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log account changes as join, not mode console level. #1696

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DasBrain
Copy link
Contributor

@DasBrain DasBrain commented Oct 7, 2024

(Only channel ops can change modes, users can change their own account)

Found by: DasBrain
Patch by: DasBrain
Fixes:

One-line summary:
Account changes are logged using +j (join, parts, quits, aways and netsplits) not +k (kick, bans and mode changes) console level.

Additional description (if needed):

Test cases demonstrating functionality (if applicable):

(Only channel ops can change modes, users can change their own account)
@thommey
Copy link
Member

thommey commented Oct 14, 2024

what's the rationale for changing it? we deliberately thought JOIN is suitable

@DasBrain
Copy link
Contributor Author

DasBrain commented Oct 14, 2024

Currently account changes are logged as mode changes, not join.

A channel member doing a /msg NickServ identify should is not a mode change, which may for example be audited.
(A log with mode changes/kicks can be used as audit log for operator actions - an ordinary channel member logging some stuff in there doesn't fit it in my opinion.)

So I agree:

we deliberately thought JOIN is suitable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants