* Update CI for ruby 3.4

egonSchiele · Dec 26, 2024 · c9d75e6 · c9d75e6
1 parent c9dcb82
commit c9d75e6
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/.github/workflows/code_style_checks.yaml b/.github/workflows/code_style_checks.yaml
@@ -24,7 +24,7 @@ jobs:
         os:
           - ubuntu
         ruby:
-          - "3.3"
+          - "3.4"
     runs-on: ${{ matrix.os }}-latest
     steps:
       - name: Checkout

diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -24,10 +24,11 @@ jobs:
         os:
           - ubuntu-latest
         ruby:
-          - "3.3"
-          - "3.2"
-          - "3.1"
           - "3.0"
+          - "3.1"
+          - "3.2"
+          - "3.3"
+          - "3.4"
         allow_failures:
           - false
         include:

diff --git a/Gemfile b/Gemfile
@@ -6,7 +6,13 @@ gemspec
 
 group :test do
   gem "aruba"
-  gem "cucumber", "~> 9.2"
+  if RUBY_VERSION >= '3.4'
+    # Cucumber is broken on Ruby 3.4, requires the fix in
+    # https://github.com/cucumber/cucumber-ruby/pull/1757
+    gem "cucumber", ">= 9.2", git: 'https://github.com/cucumber/cucumber-ruby'
+  else
+    gem "cucumber", "~> 9.2"
+  end
   gem "rspec"
 
   gem "rubocop", ">= 1.0.0"
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,7 +24,7 @@ jobs: @@
             os:
               - ubuntu
             ruby:
-              - "3.3"
+              - "3.4"
         runs-on: ${{ matrix.os }}-latest
         steps:
           - name: Checkout
@@ Expand Down @@