Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of updates! #53

Closed
wants to merge 18 commits into from
Closed

A number of updates! #53

wants to merge 18 commits into from

Conversation

ehsteve
Copy link
Owner

@ehsteve ehsteve commented Dec 7, 2023

This merge request does a number of things and should end up forming the basis for the next release.

@ehsteve
Copy link
Owner Author

ehsteve commented Dec 7, 2023

@samaloney, would you mind reviewing this?

@ehsteve
Copy link
Owner Author

ehsteve commented Dec 7, 2023

@samaloney also, i would appreciate your input on whether it is worth keeping using poetry. I am finding that I don't use it enough and end up forgetting how to use it and have to relearn it every time. On the other hand, deploying to pypi using poetry is a pleasure.

@ehsteve
Copy link
Owner Author

ehsteve commented Dec 23, 2023

@samaloney I got the web app up and running on Heroku again see https://roentgen-069cf7954bb2.herokuapp.com/gui.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d66fbad) 100.00% compared to head (cca8429) 99.64%.

Files Patch % Lines
roentgen/lines/lines.py 96.96% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #53      +/-   ##
===========================================
- Coverage   100.00%   99.64%   -0.36%     
===========================================
  Files            7        7              
  Lines          253      280      +27     
===========================================
+ Hits           253      279      +26     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehsteve ehsteve mentioned this pull request Dec 24, 2023
@ehsteve
Copy link
Owner Author

ehsteve commented Mar 7, 2024

Closing as this is superseded by #54

@ehsteve ehsteve closed this Mar 7, 2024
@samaloney
Copy link
Contributor

I actually did review this, the only part I couldn't really check was the gui and I was waiting to do that and then forgot.

@samaloney also, i would appreciate your input on whether it is worth keeping using poetry.

I certainly have to look it up each time as I don't use it on another projects and it's not used in many/any of the other sunpy projects. But is it worth the effort of switching back I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants