ep/eA Performance Test Scripts #486
Conversation
github-actions
bot
added
the
topic: infrastructure
|
An example of the ep test |
Chao1009
force-pushed
the
ep_performance_test
branch
from
8a59f4c
to
1b6f529
Compare
|
@Chao1009 This is very helpful, but why do the individual detector entries not seem to fill anytime, but "all_ff" does - what is it actually checking? |
|
Why does the e_beamline have anything to do with protons? |
It's the electron beampipe. Sorry for the confusing naming. |
This is to check the "process time" for each detector component in the
|
|
Ah okay, so if you have a significant number of particles hitting the
electron beam-pipe, then you likely don't have the crossing angle applied.
What input sample are you using for the testing?
…On Wed, Aug 30, 2023 at 9:25 AM Chao Peng ***@***.***> wrote:
Why does the e_beamline have anything to do with protons?
It's the electron beampipe. Sorry for the confusing naming.
—
Reply to this email directly, view it on GitHub
<#486 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADABSF7JWZ3TUKYALZ6ZIU3XX45M7ANCNFSM6AAAAAA2QYR6EM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
-------------------------------------------------------------
Alex Jentsch
Assistant Staff Scientist, EIC Directorate
Brookhaven National Laboratory
Upton, NY 11973
Bldg. 510, 2-234
Phone (office): 631-344-2139
Phone (cell): 281-726-0114
Pronouns: he/him/his
|
I am shooting single particles directly. |
|
Okay, then you need to make sure the particles have the -25mrad crossing
angle applied, otherwise the angular range is hard to make sense of.
…On Wed, Aug 30, 2023 at 9:32 AM Chao Peng ***@***.***> wrote:
Ah okay, so if you have a significant number of particles hitting the
electron beam-pipe, then you likely don't have the crossing angle applied.
What input sample are you using for the testing?
I am shooting single particles directly.
—
Reply to this email directly, view it on GitHub
<#486 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADABSF6U4NRJDIBRNY3FMKDXX46FDANCNFSM6AAAAAA2QYR6EM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
-------------------------------------------------------------
Alex Jentsch
Assistant Staff Scientist, EIC Directorate
Brookhaven National Laboratory
Upton, NY 11973
Bldg. 510, 2-234
Phone (office): 631-344-2139
Phone (cell): 281-726-0114
Pronouns: he/him/his
|
wdconinc
force-pushed
the
ep_performance_test
branch
from
482c6e9
to
25b67b3
Compare
Chao1009
force-pushed
the
ep_performance_test
branch
from
25b67b3
to
b300555
Compare
for more information, see https://pre-commit.ci
|
Is there a reason not to just merge this? Doesn't it just add tests? |
|
It adds code that isn't tested in CI. Does it work? Does it still work? It isn't possible to tell when it stops working. This fits more in the snippets repository, in detector benchmarks, and only here if integrated in a CI pipeline. |
|
That's a good suggestion, I think. @Chao1009 , @ajentsch , can you move these scripts over to https://github.com/eic/snippets? |
Briefly, what does this PR introduce?
This PR introduces tools to investigate the ep/eA simulation performance issue (currently it is too slow).
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No, it only adds tools
Does this PR change default behavior?
No.