Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orizaba is default Eiffel protocol #232

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

z-sztrom
Copy link
Contributor

@z-sztrom z-sztrom commented Oct 31, 2024

Applicable Issues

Fixes eiffel-community/eiffel-remrem#14

Description of the Change

Library version increased in pom.xml.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Roman Szturc [email protected]

@z-sztrom z-sztrom self-assigned this Oct 31, 2024
@z-sztrom
Copy link
Contributor Author

Tests should be redesigned. Their current version is designed to pass using Paris edition of Eiffel protocol. Whenever other version is used, versions of events don't match and tests fail.

@z-sztrom
Copy link
Contributor Author

The following are problematic tests:

  • testSendActivityFinished and
  • testSendArtifactCreated.

Main goal of these tests is to test / endpoint (generate event) of generate service. However, the tests use templates which are part of generate service code and they are still the same, regardless of semantics library version.

Can templates from semantics library be reused for tests in generate service? Probably yes, but it needs to be investigated.

@z-sztrom
Copy link
Contributor Author

z-sztrom commented Nov 5, 2024

Tried to use semantics library to get testing events from. However, the test-related code and resources are not part of target jar file.

Possible solution could be to clone eiffel-remrem-semantics somewhere and access the test file from the cloned repository.

@z-sztrom
Copy link
Contributor Author

z-sztrom commented Nov 8, 2024

As suggested by Mattias, the test files were upgraded to match Orizaba release of semantics library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uplift REMReM Publish and Generate to Orizaba
1 participant