Run the environment provider locally #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredjn
requested changes
Feb 7, 2024
Also added a few extra checks and testability things to the ESR
t-persson
force-pushed
the
use-environment-provider-as-library
branch
from
23e355a
to
4e319f3
Compare
fredjn
reviewed
Feb 15, 2024
|
|
||
|
|
||
| class FakeDatabase: | ||
| """A fake database that follows the etcd client.""" |
There was a problem hiding this comment.
What does follow the client mean? Match the available client commands/options?
|
|
||
| self.assertEqual( | ||
| len(suite_ids), 2, "There shall only be a single test suite started." |
There was a problem hiding this comment.
The assert message here seems wrong.
fredjn
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
None
Description of the Change
Note: This is expected to fail all tests due to changes in the environment provider not being ready.
Update to use the environment provider as a library instead of calling a microservice.
Alternate Designs
There are a few things that are quite silly with this. We are creating JsonTas instances and ProviderRegistry instances etc.
We also call the environment provider in a thread and wait for Eiffel events.
It was decided that we should get this up and running as it is, before making changes to it. Since we want to make as few changes as possible per PR.
Possible Drawbacks
We are changing something that has been the same in ETOS for a long time. There may be bugs. We have not made that many functional changes and instead make adaptations in the ESR to try to mitigate bug areas.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]