Merge pull request #28 from ShlomoCode/clean-get-bundle-url

Refactor: get bundle url directly using NSWorkspace.shared.urlForApplication
ejbills · Jun 26, 2024 · dbdbf9c · dbdbf9c
2 parents 3fb6a84 + 6eed7be
commit dbdbf9c
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/DockDoor/Utilities/WindowUtil.swift b/DockDoor/Utilities/WindowUtil.swift
@@ -247,8 +247,8 @@ struct WindowUtil {
 
     /// Retrieves the active windows for a given application name.
     static func activeWindows(for applicationName: String) async throws -> [WindowInfo] {
-        func getNonLocalizedAppName(for app: NSRunningApplication) -> String? {
-            guard let bundleURL = app.bundleURL else {
+        func getNonLocalizedAppName(forBundleIdentifier bundleIdentifier: String) -> String? {
+            guard let bundleURL = NSWorkspace.shared.urlForApplication(withBundleIdentifier: bundleIdentifier) else {
                 return nil
             }
 
@@ -265,8 +265,7 @@ struct WindowUtil {
 
         for window in content.windows {
             if let app = window.owningApplication,
-               let tempApp = NSRunningApplication.runningApplications(withBundleIdentifier: app.bundleIdentifier).first,
-               let nonLocalName = getNonLocalizedAppName(for: tempApp){
+               let nonLocalName = getNonLocalizedAppName(forBundleIdentifier: app.bundleIdentifier) {
 
                 // Collect potential matches
                 if applicationName.contains(app.applicationName) || app.applicationName.contains(applicationName) {