Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0 #1053

Closed
8 tasks done
ejeschke opened this issue Jun 30, 2023 · 13 comments
Closed
8 tasks done

Release 5.0 #1053

ejeschke opened this issue Jun 30, 2023 · 13 comments
Assignees
Milestone

Comments

@ejeschke ejeschke added this to the 5.0 milestone Jun 30, 2023
@ejeschke ejeschke mentioned this issue Jun 30, 2023
2 tasks
@ejeschke
Copy link
Owner Author

Skip #805 as it is likely to never be merged in favor of something implementing #1056

@ejeschke
Copy link
Owner Author

ejeschke commented Jul 21, 2023

@pllim, I'm thinking for v5.0 we should update the requirements for python (3.7 => 3.8), astropy (3.2 => 4.2) and numpy (1.14 => 1.22). What do you think?

@pllim
Copy link
Collaborator

pllim commented Jul 24, 2023

astropy 4.2 is pretty old. Is there a reason why you cannot bump it to 5.x ?

@ejeschke
Copy link
Owner Author

When is the end of support for 4.2? I mostly don't want to pull the rug out from anyone that is stuck in an older set of packages. This is true for some observatories, especially. Although our main observing software is using astropy 5.x, some of the instruments and their pipelines are stuck in older versions.

@pllim
Copy link
Collaborator

pllim commented Jul 24, 2023

astropy 4.x reached EOL when astropy 5.0 came out, so that was back in Jan 27, 2022. And we will stop supporting 5.x when we release astropy 6.0 at the end of 2023 (after about 2 years since release). As per APE 21, starting in 6.0, we no longer do LTS, so that means 6.0 is not guaranteed to receive bugfix for the next 2 years (it might but we just don't make that promise anymore). Hope this clarifies the matter.

@ejeschke
Copy link
Owner Author

I followed that "dropping LTS" discussion with interest. I suppose we can bump up the requirement to 5.0.

@pllim
Copy link
Collaborator

pllim commented Jul 24, 2023

If you bump to astropy 5.x, Python 3.8 and numpy 1.22 sound reasonable. I just cannot say for astropy 4.x because we have not been testing it for over a year.

@ejeschke
Copy link
Owner Author

Following bump to python 3.8, I think we can change this module in the same update.

@ejeschke
Copy link
Owner Author

As author of the these PRs, I request not to merge #761 (needs more testing with current version) and #1015 (not full ready, IMO) for release 5.0

@ejeschke
Copy link
Owner Author

SInce there doesn't seem much interest in #813, I suggest to not merge that for release 5.0 as well.

@pllim
Copy link
Collaborator

pllim commented Oct 28, 2023

We played with the idea of plugging in reproject into Jdaviz too but abandoned it because it is too resource intensive.

@ejeschke
Copy link
Owner Author

Kicking the can on #698, #823 and #940 down the road for possible resolution in a future release.

@ejeschke
Copy link
Owner Author

Released! (or should I say "Unleashed" 😸 )

@ejeschke ejeschke self-assigned this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants