Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bedrock): add bedrock custom models, customization jobs, provisioned throughput and logging configuration #161

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

npellegrin
Copy link
Contributor

Closes #160

@npellegrin
Copy link
Contributor Author

npellegrin commented May 3, 2024

I have not tested this part on real infrastructure for now. Will try to write some unit tests 😃

The current GO SDK version prevent implementing Bedrock Guardrails and Bedrock Evaluation Jobs, I will put it in another PR to have this one green.

@ekristen
Copy link
Owner

ekristen commented May 3, 2024

Mocks would be a good place to start. I do have examples of integration tests that require full AWS credentials to run.

Look for _mock_test.go for mock related on how to create the mocks for the service. Writing mocks requiring some additional alterations to the source. Ideally since this is net new we want to run against real resources too or at least get real outputs back from the API to create the mocks to ensure we have proper coverage.

@ekristen
Copy link
Owner

@npellegrin are you going to have time to finish this up or should we close it for the time being?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bedrock resources
2 participants