Fix NPE in dropped spans stats (#3590)

* fix npe * update changelog
elastic · May 2, 2024 · b14f658 · b14f658
1 parent c339b00
commit b14f658
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
@@ -34,6 +34,7 @@ Use subheadings with the "=====" level for adding notes for unreleased changes:
 [float]
 ===== Bug fixes
 * Fixed edge case where inferred spans could cause cycles in the trace parent-child relationships, subsequently resulting in the UI crashing - {pull}3588[#3588]
+* Fix NPE in dropped spans statistics - {pull}3590[#3590]
 
 [[release-notes-1.x]]
 === Java Agent version 1.x

diff --git a/apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/DroppedSpanStats.java b/apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/DroppedSpanStats.java
@@ -190,10 +190,13 @@ public void captureDroppedSpan(Span span) {
     private Stats getOrCreateStats(ServiceTarget serviceTarget, Outcome outcome) {
         StatsKey statsKey = statsKeyObjectPool.createInstance().init(serviceTarget, outcome);
         Stats stats = statsMap.get(statsKey);
-        if (stats != null || statsMap.size() > 127) {
+        if (stats != null) {
             statsKeyObjectPool.recycle(statsKey);
             return stats;
         }
+        if (statsMap.size() > 127) {
+            statsKeyObjectPool.recycle(statsKey);
+        }
 
         stats = statsObjectPool.createInstance();