Exclude virtual threads from inferred spans feature #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
added
the
ci:jdk-compatibility
|
/test |
SylvainJuge
approved these changes
Aug 9, 2023
Comment on lines
+42
to
+54
| /** | ||
| * Generates a VirtualChecker based on the current JVM. | ||
| * If the JVM does not support virtual threads, a VirtualChecker which always returns false is returned. | ||
| * <p> | ||
| * Otherwise we runtime generate an implementation which invokes Thread.isVirtual(). | ||
| * We use runtime proxy generation because Thread.isVirtual() has been added in Java 19 as preview and Java 21 as non preview. | ||
| * Therefore we would require a compilation with Java 19 (non-LTS), because Java 20+ does not allow targeting Java 7. | ||
| * <p> | ||
| * Alternatively we could simply invoke Thread.isVirtual via reflection. | ||
| * However, because this check can be used very frequently we want to avoid the penalty / missing inline capability of reflection. | ||
| * | ||
| * @return the implementation for {@link VirtualChecker}. | ||
| */ |
There was a problem hiding this comment.
Nice ! I think that's definitely a good approach we could use for other deprecated or soon-to-be-removed APIs like the security manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Excludes virtual threads from the inferred spans feature. Before doing this I did a short test, showing that our async-profiler version can't deal with virtual threads switching their carrier thread.
Checklist