Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: for local types prefer sizeof() #173

Merged
merged 1 commit into from
Sep 13, 2023
Merged

bpf: for local types prefer sizeof() #173

merged 1 commit into from
Sep 13, 2023

Conversation

nicholasberlin
Copy link
Contributor

No description provided.

@nicholasberlin nicholasberlin requested a review from a team as a code owner September 13, 2023 14:13
mmat11
mmat11 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

norrietaylor
norrietaylor approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@norrietaylor norrietaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicholasberlin nicholasberlin merged commit b984e85 into main Sep 13, 2023
36 of 37 checks passed
@nicholasberlin nicholasberlin deleted the nberlin/sizeof_instead_of_bpf_core_size_of branch September 13, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmat11 mmat11 mmat11 approved these changes

@norrietaylor norrietaylor norrietaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholasberlin @mmat11 @norrietaylor