Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps wc: Add admission.gatekeeper.sh/ignore label to kube-system and gatekeeper-system namespaces #140

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

jakubkrzywda
Copy link
Contributor

@jakubkrzywda jakubkrzywda commented Dec 15, 2020

What this PR does / why we need it: This PR adds admission.gatekeeper.sh/ignore="true" label to kube-system and gatekeeper-system namespaces.

Which issue this PR fixes:
fixes #148

Public facing documentation PR (if applicable)

Special notes for reviewer:

Checklist:

  • Added relevant notes to WIP-CHANGELOG.md
  • Proper commit message prefix on all commits
  • Updated the public facing documentation
  • Is this changeset backwards compatible for existing clusters? Applying:
    • is completely transparent, will not impact the workload in any way.
    • requires running a migration script.
    • will create noticeable cluster degradation.
      E.g. logs or metrics are not being collected or Kubernetes API server
      will not be responding while upgrading.
    • requires draining and/or replacing nodes.
    • will change any APIs.
      E.g. removes or changes any CK8S config options or Kubernetes APIs.
    • will break the cluster.
      I.e. full cluster migration is required.

@jakubkrzywda jakubkrzywda force-pushed the control-plane-label-for-namespaces branch from 1e618a1 to 22a3a44 Compare December 15, 2020 12:12
@jakubkrzywda jakubkrzywda changed the title apps wc: Add control-plane label to kube-system namespace apps wc: Add control-plane label to kube-system and gatekeeper-system namespaces Dec 15, 2020
@jakubkrzywda jakubkrzywda changed the title apps wc: Add control-plane label to kube-system and gatekeeper-system namespaces apps wc: Add admission.gatekeeper.sh/ignore label to kube-system and gatekeeper-system namespaces Feb 10, 2021
@jakubkrzywda jakubkrzywda marked this pull request as ready for review February 10, 2021 16:24
@OlleLarsson
Copy link
Contributor

fixes #148

@tordsson tordsson merged commit be0b8f3 into main Feb 18, 2021
@tordsson tordsson deleted the control-plane-label-for-namespaces branch February 18, 2021 11:36
@pettersv pettersv mentioned this pull request Apr 7, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants