fix: remove now-unusable "legacy" notarization #187
Conversation
|
note: I took pains to make this backwards-compatible. If you’d rather I remove the obsolete types outright, I could do that instead. |
dsanders11
changed the title
|
Really appreciate this @rotu! Had some comments about the docs, someone else has to look at the code bits. I'll leave it to that person whether the error message about legacy should also point to notarytool instead. |
|
@MarshallOfSound How do I get code review on this? |
There was a problem hiding this comment.
Seems legit, @rotu we talked about this and based on our policy RE typescript types you can also remove the types in a follow up if you want. This thing doesn't work, removing it can't be considered semver/major in any form. If anything it just fails peoples builds earlier which IMO is better.
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Updated API to reflect deprecated exports.
Updated documentation to match.
Removed code that will no longer work.