Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: Jquery gets elements by Id. #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denniscastro
Copy link

Before: just get first elemment
Now: gets all the elements with same Id

Before: just get first elemment
Now: gets all the elements with same Id
@iamvery
Copy link

iamvery commented Jul 3, 2012

Its probably a bad idea overall to have duplicate HTML id attributes on the page anyway. Since this lib does so when multi-day events "wrap", it'd probably be a good idea to revert back to the "class style" event identification (i.e. ec-event-1234) and additionally include a more general class ec-event along with it).

For that matter, couldn't you even match the CSS class ec-event-1234 with something like [class*="ec-event"]?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants