-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Integration tests #1
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,8 @@ | |||
-module('Elm.Native.Utils'). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elm.Native.*
should not be implemented here, I'm thinking of having a new repo on the elmer-compiler organization that mirror those from elm-lang, for example one repo for core, one for html, etc, and they MUST use the same semantic version than the package from elm. So for example, Elm.Native.Utils
should be on elmer-core
etc. IIRC the elm-compiler just concatenates those Native javascript modules when everything is compiled to javascript. But we must require the user to list each elmer-* native package as another erlang dependency at runtime.
@@ -60,6 +60,10 @@ dump(erlsrc, Filename, Erl) -> | |||
Bin = erlang:iolist_to_binary(Src), | |||
{Filename, Bin}; | |||
|
|||
dump(binary, Filename, Erl) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only thing that should be merged then. Perhaps changing the atom to beam
could be more explicit.
I'll fix the test to only verify that a compiled beam can be loaded and executed from erlang.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the original idea was to have a dump({beam, OutputDirectory}, Filename, Erl)
function, that's what would get called by the rebar3_elmer plugin
ec3d6d3
to
8e5f7b3
Compare
No description provided.