Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document system-level environment variables for file-based pipeline nodes #3243

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

shalberd
Copy link
Contributor

Document system-level environment variables for file-based pipeline nodes at level Jupyterlab, KFP or Airflow runtime, or both.
Follow-up to #3227

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@shalberd
Copy link
Contributor Author

I layed this out conceptually in terms of where the system-level envs apply to, i.e. Jupyterlab or at runtime Airflow and KFP or both (scope).

@harshad16 what should I write about ELYRA_WRITABLE_CONTAINER_DIR? This is only actually used in KFP.

@shalberd shalberd force-pushed the document_envs branch 2 times, most recently from a88a502 to def2fca Compare August 27, 2024 13:53
…odes at level Jupyterlab, KFP or Airflow runtime, or both

Signed-off-by: shalberd <[email protected]>
@lresende lresende merged commit 76f7b26 into elyra-ai:main Sep 2, 2024
17 checks passed
@shalberd
Copy link
Contributor Author

shalberd commented Sep 6, 2024

@lresende Thank you. Now we just need to pull this, I guess, from readthedocs, which is I guess related to #3205 .
Does there exist an elyra-related readthedocs account?
@romeokienzler FYI

@lresende
Copy link
Member

lresende commented Sep 6, 2024

#3245 should fix the doc build

@lresende
Copy link
Member

lresende commented Sep 7, 2024

https://elyra.readthedocs.io/en/latest/user_guide/env-variables-file-based-nodes.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants