-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Leaderboard UI improvements #1370
Conversation
Would change: Discussion points: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the table improvements!
In general, I don't see why we are changing some of the components unless they are based on collected feedback.
- Search: Is it possible to replicate the current leaderboard search i.e. separate multiple queries with
;
? If not, I'd prefer to retain that instead of replacing it with regex. Ref: Leaderboard 2.0: Re-add model searchbar from 1.0 #1347 - Defaults: Current leaderboard has both "open" and "proprietary" selected, and both with/ without instructions selected.
- Benchmark: What is the expected use of the filters underneath "Benchmarks"? Are users expected to select a benchmark, then add more filters if desired?
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few small suggestions.
Co-authored-by: Isaac Chung <[email protected]>
Co-authored-by: Isaac Chung <[email protected]>
Improvements:
Implemented the following things:
Screenshot: