-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add Korean AutoRAGRetrieval #1388
Conversation
ruff format . # running ruff formatting 716 files left unchanged ruff check . --fix # running ruff linting All checks passed!
Hello, I tried to contribute this AutoRAGRetrieval task, but I got some errors while testing. Can I please get some help? Thank you. |
date=None, | ||
form=None, | ||
domains=None, | ||
task_subtypes=None, | ||
license=None, | ||
socioeconomic_status=None, | ||
annotations_creators=None, | ||
dialect=None, | ||
text_creation=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the metadata is not filled out you will get an error in the tests. Let me know if there are any problems with these.
@yjoonjang I think we are almost there. Will you complete the checklist for adding a new dataset? I also want to double check that annotations are human and not LLM generated? |
Hello, @KennethEnevoldsen
|
I tried to run your code and maybe you need to reinstall your package to fix your problems, because I can run task like this |
I still had the same error, but I ran the test by python code. Thank you, @KennethEnevoldsen @Samoed |
I have deleted the |
This corresponds with the results I attatched on the checklist above! |
Results for the |
Oh yes. I tested with |
e5 does use prompts though they are minimal (e.g. "query: " ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things looks good on my end - @Samoed feel free to merge this in if you feel the same
Thank you so much for your help. |
@yjoonjang we no longer take point for the MMTEB contribution (it has already been submitted). However you will appear as a contributor on MTEB. |
Adding datasets checklist
Reason for dataset addition:
This is a Korean Retrieval benchmark dataset covering 5 domains: Finance, Public, Medicine, Law, Commerce
mteb -m {model_name} -t {task_name}
command.sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
{"ndcg_at_1": 0.29825, "ndcg_at_5": 0.3973, "ndcg_at_10": 0.42296}
intfloat/multilingual-e5-small
{"ndcg_at_1": 0.59649, "ndcg_at_5": 0.73205, "ndcg_at_10": 0.75466}
self.stratified_subsampling() under dataset_transform()
make test
.make lint
.