-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix test for empty descriptive tasks #1413
base: v2.0.0
Are you sure you want to change the base?
fix: Fix test for empty descriptive tasks #1413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This of course causes the tests to fail, if possible it would be great to run calculate descriptive stats for all datasets (maybe with a few exceptions).
Oh, I missed that test not passing. I'm preparing an update to descriptive stats, and after that I think I can try to calculate on some datasets |
Moving this to v2.0.0, but we could move it back if it makes things easier |
@KennethEnevoldsen Tests are fixed. I think this is ready to merge into main for now. If anyone wants to add new tasks, this test should be helpful. Future updates to descriptive stats could be planned for version 2.0.0. |
Shouldn't the test fail? GIven that most datasets don't have descriptive stats? |
I've added current tasks without metadata to exceptions like in |
Hmm, we might be misunderstanding each other. A task like "TbilisiCityHallBitextMining" no longer has descriptive statistics, but did have it beforehand. |
dd0f5f0
to
ddd04ab
Compare
I updated the test. Now, if a task is in the exceptions list (tasks currently without descriptive stats) and has metadata, it will raise an error. Otherwise, descriptive stats are required. |
Checklist
make test
.make lint
.It seems that when creating the test, I missed recreating the array in the test case, which caused the test to not work correctly. Fixes #1412