Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix test for empty descriptive tasks #1413

Open
wants to merge 5 commits into
base: v2.0.0
Choose a base branch
from

Conversation

Samoed
Copy link
Collaborator

@Samoed Samoed commented Nov 8, 2024

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

It seems that when creating the test, I missed recreating the array in the test case, which caused the test to not work correctly. Fixes #1412

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This of course causes the tests to fail, if possible it would be great to run calculate descriptive stats for all datasets (maybe with a few exceptions).

@Samoed
Copy link
Collaborator Author

Samoed commented Nov 11, 2024

Oh, I missed that test not passing. I'm preparing an update to descriptive stats, and after that I think I can try to calculate on some datasets

@KennethEnevoldsen KennethEnevoldsen changed the base branch from main to v2.0.0 November 11, 2024 09:26
@KennethEnevoldsen
Copy link
Contributor

Moving this to v2.0.0, but we could move it back if it makes things easier

@Samoed
Copy link
Collaborator Author

Samoed commented Nov 11, 2024

@KennethEnevoldsen Tests are fixed. I think this is ready to merge into main for now. If anyone wants to add new tasks, this test should be helpful. Future updates to descriptive stats could be planned for version 2.0.0.

@KennethEnevoldsen
Copy link
Contributor

Shouldn't the test fail? GIven that most datasets don't have descriptive stats?

@Samoed
Copy link
Collaborator Author

Samoed commented Nov 11, 2024

I've added current tasks without metadata to exceptions like in test_disallow_trust_remote_code_in_new_datasets

@KennethEnevoldsen
Copy link
Contributor

Hmm, we might be misunderstanding each other. A task like "TbilisiCityHallBitextMining" no longer has descriptive statistics, but did have it beforehand.

@Samoed
Copy link
Collaborator Author

Samoed commented Nov 13, 2024

I updated the test. Now, if a task is in the exceptions list (tasks currently without descriptive stats) and has metadata, it will raise an error. Otherwise, descriptive stats are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

descriptive stats missing for multiple datasets
2 participants