Fix: Add missing benchmarks in benchmarks.py #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KennethEnevoldsen
requested review from
isaac-chung and
Muennighoff
and removed request for
isaac-chung
Muennighoff
approved these changes
Nov 11, 2024
isaac-chung
deleted the
KennethEnevoldsen/issue-Add-missing-benchmarks-in-benchmarkspy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@x-tabdeveloping the Bright retrieval will probably look a bit odd. Is there a way to split a task into multiple columns?
Fixes #1423
Checklist
make test.make lint.