Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new models nvidia, gte, linq #1436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexeyVatolin
Copy link
Contributor

Added two gte, nvidia and linq models to model registry

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Adding a model checklist

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.

For testing I took the examples from the huggingface model card and compared the results with the results from the mteb model registry. In all new models, the text distance scores matches in at least 3 figures

Copy link
Collaborator

@Samoed Samoed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! Can you submit results?

mteb/models/nvidia_models.py Outdated Show resolved Hide resolved
mteb/models/nvidia_models.py Show resolved Hide resolved
@AlexeyVatolin
Copy link
Contributor Author

Great changes! Can you submit results?

What do you mean, results on one arbitrary task from English MTEB?

@Samoed
Copy link
Collaborator

Samoed commented Nov 11, 2024

On some tasks from leaderboard to make sure that implementation matching

mteb/models/gte_models.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants