Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard: Fixed code benchmarks #1441

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Leaderboard: Fixed code benchmarks #1441

merged 9 commits into from
Nov 13, 2024

Conversation

x-tabdeveloping
Copy link
Collaborator

Along with updating the selected values, I also update the choices in the dropdowns.

@x-tabdeveloping
Copy link
Collaborator Author

x-tabdeveloping commented Nov 12, 2024

@Muennighoff I added a fix for the bug you encountered. I think the problem lied in Jina having an incorrect number of parameters in the metadata though (572K instead of 572M)

@x-tabdeveloping
Copy link
Collaborator Author

Actually, I didn't fix it, I encountered yet another bug in Gradio I have to work around :)))))))

Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you could attach screenshots of the changes in the UI, that'd be great as well :)

@KennethEnevoldsen
Copy link
Contributor

This looks good so far @x-tabdeveloping, let us go through it in person today to get most of the kinks removed (I have a meeting at 15) and figure out what is needed before a final review among colaborators

@x-tabdeveloping
Copy link
Collaborator Author

@isaac-chung the UI largely remained the same, no significant changes there

@x-tabdeveloping x-tabdeveloping merged commit 3a1a470 into main Nov 13, 2024
10 checks passed
@x-tabdeveloping x-tabdeveloping deleted the code_fix branch November 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants