Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unsure TaskResults can handle runtime and version being unspecified #1447

Closed
wants to merge 2 commits into from
Closed

fix: Unsure TaskResults can handle runtime and version being unspecified #1447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a8a370
fix: Unsure TaskResults can handle runtime and version being unspecified
KennethEnevoldsen Nov 14, 2024
dea2b77
Merge branch 'v2.0.0' of https://github.com/embeddings-benchmark/mteb…
KennethEnevoldsen Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions mteb/load_results/task_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,9 @@ class TaskResult(BaseModel):

dataset_revision: str
task_name: str
mteb_version: str
mteb_version: str | None
scores: dict[Split, list[ScoresDict]]
evaluation_time: float
evaluation_time: float | None
kg_co2_emissions: float | None = None

@classmethod
Expand Down Expand Up @@ -290,6 +290,9 @@ def from_disk(cls, path: Path, load_historic_data: bool = True) -> TaskResult:
f"Error loading TaskResult from disk. You can try to load historic data by setting `load_historic_data=True`. Error: {e}"
)

if data["mteb_version"] is None:
data.pop("mteb_version")

pre_1_11_load = (
(
"mteb_version" in data
Expand Down
Loading