Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update task metadata to allow for null #1448

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

KennethEnevoldsen
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen commented Nov 14, 2024

See embeddings-benchmark/results#43

Should allow us to use null for both version and evaluation time.

Should also be merged into v2.0.0

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

@KennethEnevoldsen KennethEnevoldsen merged commit 04ac3f2 into main Nov 14, 2024
10 checks passed
@KennethEnevoldsen KennethEnevoldsen deleted the fix--update-task-metadata-to-allow-for-null branch November 14, 2024 10:53
KennethEnevoldsen added a commit that referenced this pull request Nov 14, 2024
* fix: Count unique texts, data leaks in calculate metrics (#1438)

* add more stat

* add more stat

* update statistics

* fix: update task metadata to allow for null (#1448)

* Update tasks table

* 1.19.5

Automatically generated by python-semantic-release

* base

* sync with main

---------

Co-authored-by: Kenneth Enevoldsen <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant