Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pharia data english #75

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MaxMeuer
Copy link

@MaxMeuer MaxMeuer commented Dec 19, 2024

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the results files checker make pre-push.

@Samoed
Copy link
Collaborator

Samoed commented Dec 19, 2024

Can you add implementation of your model to mteb repo?

@MaxMeuer
Copy link
Author

For now we would keep it with trust_remote_code in the checkpoint repo if possible.
We need to unify codebases from CausalLM model and put it on HF too. I don't think that will happen until EOY so ideally I would like to merge this branch before.

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things to clarify

For now we would keep it with trust_remote_code in the checkpoint repo if possible.
We need to unify codebases from CausalLM model and put it on HF too. I don't think that will happen until EOY so ideally I would like to merge this branch before.

This is perfectly fine. However a PR to mteb can simply be the metadata without the implementation (or the implementation using an API).

"open_weights": true,
"public_training_data": null,
"public_training_code": true,
"framework": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"framework": [],
"framework": ["API"],

Assuming?

"public_training_data": null,
"public_training_code": true,
"framework": [],
"reference": null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this

"public_training_code": true,
"framework": [],
"reference": null,
"similarity_fn_name": null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"similarity_fn_name": null,
"similarity_fn_name": "cosine",

"dataset_revision": "e8379541af4e31359cca9fbcf4b00f2671dba205",
"evaluation_time": 25.99530529975891,
"kg_co2_emissions": null,
"mteb_version": "1.14.21",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the latest version is not used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants