Initial comments #13
Open
Initial comments #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Trenton!
Here's my initial round of small things to change, and then maybe it's just because it's latish at night, but I got confused about forward vs. reverse acceleration, and after reading the rest of the README.md file I think my confusion I around the fact that negative acceleration does not move the car backwards. That was/still kind of is confusing to me, so it would be great to maybe have more information about that in the README.md file so it's more clear, and then I'll take a look at that paragraph to implement the other acceleration functions.
I was able to test the car with the graphics though which was cool! Unfortunately I have used Turtle Graphics before, so not sure if I would have had to install it if it was my first time, but it was great!