Merge pull request #2200 from wagenet/fix-lifecycle-hook-in-double-ex…

…tend Fix no-component-lifecycle-hook in double extended classic component
ember-cli · Oct 25, 2024 · cf00326 · cf00326
2 parents 49ff30c + 4427396
commit cf00326
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/lib/rules/no-component-lifecycle-hooks.js b/lib/rules/no-component-lifecycle-hooks.js
@@ -36,22 +36,25 @@ module.exports = {
     let isInsideEmberComponent = false;
     let isInsideGlimmerComponent = false;
     let currentComponentNode = null;
+    let isInsideClassDeclaration = false;
 
     return {
       // Native class.
       ClassDeclaration(node) {
         if (isEmberComponent(context, node)) {
           currentComponentNode = node;
           isInsideEmberComponent = true;
+          isInsideClassDeclaration = true;
         } else if (isGlimmerComponent(context, node)) {
           currentComponentNode = node;
           isInsideGlimmerComponent = true;
+          isInsideClassDeclaration = true;
         }
       },
 
       // Classic class (not used by Glimmer components).
       CallExpression(node) {
-        if (isEmberComponent(context, node)) {
+        if (isEmberComponent(context, node) && !isInsideClassDeclaration) {
           currentComponentNode = node;
           isInsideEmberComponent = true;
         }
@@ -62,11 +65,12 @@ module.exports = {
           currentComponentNode = null;
           isInsideEmberComponent = false;
           isInsideGlimmerComponent = false;
+          isInsideClassDeclaration = false;
         }
       },
 
       'CallExpression:exit'(node) {
-        if (currentComponentNode === node) {
+        if (currentComponentNode === node && !isInsideClassDeclaration) {
           currentComponentNode = null;
           isInsideEmberComponent = false;
         }

diff --git a/tests/lib/rules/no-component-lifecycle-hooks.js b/tests/lib/rules/no-component-lifecycle-hooks.js
@@ -87,6 +87,16 @@ ruleTester.run('no-component-lifecycle-hooks', rule, {
 
       const someRandomClassOrObject = { didDestroyElement() { } };
     `,
+    `
+      import Component from '@ember/component';
+
+      export default class CommentInput extends Component.extend() {
+      }
+
+      export class CommentInput2 {
+        didDestroyElement() {}
+      }
+    `,
   ],
 
   invalid: [
@@ -167,5 +177,21 @@ ruleTester.run('no-component-lifecycle-hooks', rule, {
         },
       ],
     },
+    {
+      code: `
+        import Component from '@ember/component';
+
+        export default class CommentInput extends Component.extend() {
+          didDestroyElement() {}
+        }
+      `,
+      output: null,
+      errors: [
+        {
+          message: ERROR_MESSAGE,
+          type: 'MethodDefinition',
+        },
+      ],
+    },
   ],
 });