Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: [EmberData] Update guides to suggest include to be an array #2048

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Baltazore
Copy link

As part of discussion in emberjs/data#9502 we found that there was a long-lasting miss-understanding of include param type definition. As more and more people using TS, we need to fix it, as the type for include would be array only, not a string.

So this PR aims to correct guides and docs to suggest user to use include value as an array.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit 29503a6
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/668ce8a0222dca00084af964
😎 Deploy Preview https://deploy-preview-2048--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Baltazore Baltazore changed the title [EmberData] Update guides to suggest include to be an array Draft: [EmberData] Update guides to suggest include to be an array Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants