Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_template.md #522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create pull_request_template.md #522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82b026e
Create pull_request_template.md
MelSumner Aug 3, 2023
57ef430
Update pull_request_template.md
MelSumner Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
## EmberJS Open Meeting Notes


### Meeting Info

<!-- Replace the ALL CAPS information with the relevant data for the meeting -->
- Meeting: EVENT NAME
- Date: DATE
- Facilitator: NAME (GITHUB USERNAME)

### Agenda

Agendas have two sections:

1. Standing items: should happen every meeting
2. Additional discussion: for any other topic to be discussed

#### Standing Item: General Admin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make sense in the RFC review meeting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's something we can decide, I think. I thought it could make sense to at least have this touchpoint in different timezones to help surface urgent issues a little more easily. It could also make sense to leave it out, so whatever we decide! 👍


<!-- Facilitator notes: -->
<!-- Ask these questions and document if there are responses -->
<!-- If any of these questions have a YES response, please also post to the core meta channel in Discord. -->

- Any new, known blockers for our users in ember-source?
- Any show-stopping [issues](https://github.com/emberjs/ember.js/issues) that need more immediate attention?
- Any [pull requests](https://github.com/emberjs/ember.js/pulls) that needs more urgent review?

#### Standing Item: RFC Review

<!-- Facilitator notes:

Review each type of RFC PR and determine if there are any **NEW** comments or feedback.
Document discussion (the general gist) in these notes.
Try to document concerns raised in the RFC PR itself.

Important note: it may not be possible to get through each section in a single meeting, that's fine!
You can determine as the facilitator what is most useful for that meeting.

-->

TODO:
- [ ] Review new comments or feedback in the RFC, and the checklist in each PR description.
- [ ] Determine if there are any new actions to take, or if any checkboxes have been completed.
- [ ] Update this document with notes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like this template pertains only to the RFC review meetings. I think we had said that we wouldn't be taking notes for those meetings but would record outcomes on the particular RFCs. Am I remembering that correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fair but also then makes me wonder if there's a point to having notes at all if we're not going to write down what was reviewed/discussed?

WDYT?


RFC Categories:
1. [Exploring](https://github.com/emberjs/rfcs/labels/S-Exploring)
2. [Proposed](https://github.com/emberjs/rfcs/labels/S-Proposed)
3. [Ready for Release](https://github.com/emberjs/rfcs/labels/S-Ready%20for%20Release)
4. [Released](https://github.com/emberjs/rfcs/labels/S-Recommended)
5. [Recommended](https://github.com/emberjs/rfcs/labels/S-Released)

<!-- #### Additional Discussion -->