Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ld-bg-cells): add mtrust cells #1127

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

leabarth
Copy link

@leabarth leabarth commented Oct 8, 2024

Description

Adds M-Trust cells.

Fixes MDEV-484

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Is it a breaking change?

  • Yes
  • No

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing tests pass locally with my changes

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquid ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 1:52pm

@leabarth leabarth marked this pull request as ready for review October 9, 2024 07:55
Copy link
Member

@renet renet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline seems to be broken, as well. Can you please have a look?

src/liquid/components/ld-typo/readme.md Outdated Show resolved Hide resolved
src/liquid/components/ld-bg-cells/readme.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants