-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial PR for a new structure of exceptions. #9
Conversation
Extensions? You mean exceptions? |
yes, sorry for the confusion 😉 Before merging I suggest to discuss if the new structure makes sense, and then continue with some more examples before a final merge. |
No problem ^^. Could you please fix the merge conflict, that the tests can run? |
LGTM, but ffs should be renamed to something more descriptive. |
Thanks for the contribution @KochC . I need to review this properly - please keep it open for now. |
We will also need deprecation warnings, otherwise it may instantly break code other people wrote. |
At the end before merging into the main branch, I suggest to squash the commits into one and reference the issue you raised in the commit message by adding "(#5)" at the end of the commit message. |
Summary
Initial PR for a new structure of exceptions.
Checklist