Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XmlRpc DownloadSubtitles instead of direct link #71

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

Tony4dev
Copy link
Contributor

@Tony4dev Tony4dev commented Feb 23, 2021

This is related to #70 the problem is that the program uses hard-coded URL instead of XmlRpc API.

Thanks to using the API the download method doesn't have to be different per environment. Also, maybe some dependencies may be removed. The code might probably need some polishing, I am not that familiar with Python.

Also notice, that I only fixed the usage per item (subtitle), but the subs could be downloaded in bulk (one request, could help with #44 ), maybe it would be worth to refactor the code to reflect that too.

@emericg
Copy link
Owner

emericg commented Feb 23, 2021

Hi! This looks promising I'll have a look at it tomorrow, but you did nuke a couple of features, including the download UI ^^

@Tony4dev
Copy link
Contributor Author

Hi! This looks promising I'll have a look at it tomorrow, but you did nuke a couple of features, including the download UI ^^

Yeah, you might want to refactor and test it properly, I only had lunchtime for this and tested it only few times locally on Gnome. Or just use it as a guideline, because I think it would be really nice if all subs could be loaded in one request as mentioned above, but it needs broader refactor than I can provide with my limited knowledge and time.

@emericg
Copy link
Owner

emericg commented Mar 30, 2021

I'm accepting this pull request so you get the commit credit, but I'll revert everything that's not related to XmlRpc download and only in CLI mode (for now).
I'm still not sure what to do regarding the GUI download progressbar... The way it is done now, the download window and wget are run simultaneously, and you can both see how much time the download take and get a chance to cancel it if you want, which I think is cool.

@emericg emericg merged commit 5a0ae93 into emericg:master Mar 30, 2021
@Tony4dev
Copy link
Contributor Author

Thanks, hopefully somebody else can help you with the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants