Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't always change lastTransitionTime of pod conditon #1000

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jan 9, 2024

More info: #998 (comment)

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3cc0d5) 77.08% compared to head (795e257) 76.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   77.08%   76.93%   -0.16%     
==========================================
  Files          67       67              
  Lines        6088     6091       +3     
==========================================
- Hits         4693     4686       -7     
- Misses       1173     1182       +9     
- Partials      222      223       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z changed the title chore: don't always change lastTransitionTime of pod conditon' chore: don't always change lastTransitionTime of pod conditon Jan 9, 2024
@Rory-Z Rory-Z merged commit c2e33ff into emqx:main Jan 9, 2024
32 checks passed
@Rory-Z Rory-Z deleted the chore/dont-change-pod-condition-time branch January 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant