Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix update emqx config error #1005

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jan 23, 2024

Don't update readonly keys

Don't update readonly keys

Signed-off-by: Rory Z <[email protected]>
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (b2506f8) 77.18% compared to head (58eea01) 77.08%.

Files Patch % Lines
controllers/apps/v2beta1/sync_emqx_config.go 0.00% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
- Coverage   77.18%   77.08%   -0.11%     
==========================================
  Files          67       67              
  Lines        6141     6153      +12     
==========================================
+ Hits         4740     4743       +3     
- Misses       1178     1185       +7     
- Partials      223      225       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit 06fb780 into emqx:main Jan 23, 2024
32 of 34 checks passed
@Rory-Z Rory-Z deleted the fix/dont-update-readonly-keys branch January 23, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant