Revert "fix: fix nil pointer error" #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a898dfb. Signed-off-by: Rory Z <[email protected]>
Rory-Z
force-pushed
the
revert-1067-fix/fix-empty-point
branch
from
ed22ca7
to
0358862
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
+ Coverage 76.46% 76.48% +0.01%
==========================================
Files 69 69
Lines 6251 6250 -1
==========================================
Hits 4780 4780
- Misses 1233 1234 +1
+ Partials 238 236 -2 ☔ View full report in Codecov by Sentry. |
rouke-broersma
referenced
this pull request
in broersma-forslund/homelab
Sep 24, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [emqx-operator](https://redirect.github.com/emqx/emqx-operator) ([source](https://redirect.github.com/emqx/emqx-operator/tree/HEAD/deploy/charts/emqx-operator)) | patch | `2.2.23` -> `2.2.24` | --- ### Release Notes <details> <summary>emqx/emqx-operator (emqx-operator)</summary> ### [`v2.2.24`](https://redirect.github.com/emqx/emqx-operator/releases/tag/2.2.24): EMQX Operator 2.2.24 Released [Compare Source](https://redirect.github.com/emqx/emqx-operator/compare/2.2.23...2.2.24) ### Release Note 🍻 EMQX Operator 2.2.24 has been released. #### Supported version - apps.emqx.io/v2beta1 - EMQX at 5.1.1 and later - EMQX Enterprise at 5.1.1 and later - apps.emqx.io/v1beta4 - EMQX at 4.4.14 and later - EMQX Enterprise at 4.4.14 and later #### Enhancements 🚀 - `apps.emqx.io/v2beta1 EMQX`. - Fix sometimes cannot update EMQX's configuration when EMQX is running. #### How to install/upgrade EMQX Operator 💡 > Need make sure the [cert-manager](https://cert-manager.io/) is ready helm repo add emqx https://repos.emqx.io/charts helm repo update helm upgrade --install emqx-operator emqx/emqx-operator \ --namespace emqx-operator-system \ --create-namespace \ --version 2.2.24 kubectl wait --for=condition=Ready pods -l "control-plane=controller-manager" -n emqx-operator-system #### Warning 🚨 `apps.emqx.io/v1beta3` and `apps.emqx.io/v2alpha1` will be dropped soon #### What's Changed - Docs fix: Replace all kubernetes API links by [@​Fluder-Paradyne](https://redirect.github.com/Fluder-Paradyne) in [https://github.com/emqx/emqx-operator/pull/1058](https://redirect.github.com/emqx/emqx-operator/pull/1058) - ci: push multi image to ghcr when release by [@​Rory-Z](https://redirect.github.com/Rory-Z) in [https://github.com/emqx/emqx-operator/pull/1065](https://redirect.github.com/emqx/emqx-operator/pull/1065) - chore: dump controller-gen version by [@​Rory-Z](https://redirect.github.com/Rory-Z) in [https://github.com/emqx/emqx-operator/pull/1066](https://redirect.github.com/emqx/emqx-operator/pull/1066) - fix: fix nil pointer error by [@​Rory-Z](https://redirect.github.com/Rory-Z) in [https://github.com/emqx/emqx-operator/pull/1067](https://redirect.github.com/emqx/emqx-operator/pull/1067) - Revert "fix: fix nil pointer error" by [@​Rory-Z](https://redirect.github.com/Rory-Z) in [https://github.com/emqx/emqx-operator/pull/1068](https://redirect.github.com/emqx/emqx-operator/pull/1068) - chore: dump kube version to 0.16.3 by [@​Rory-Z](https://redirect.github.com/Rory-Z) in [https://github.com/emqx/emqx-operator/pull/1074](https://redirect.github.com/emqx/emqx-operator/pull/1074) - feat: use original config to PUT EMQX configs api by [@​Rory-Z](https://redirect.github.com/Rory-Z) in [https://github.com/emqx/emqx-operator/pull/1073](https://redirect.github.com/emqx/emqx-operator/pull/1073) #### New Contributors - [@​Fluder-Paradyne](https://redirect.github.com/Fluder-Paradyne) made their first contribution in [https://github.com/emqx/emqx-operator/pull/1058](https://redirect.github.com/emqx/emqx-operator/pull/1058) **Full Changelog**: emqx/emqx-operator@2.2.23...2.2.24 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/broersma-forslund/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1067