Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: if updated sts/rs equal current sts/rs, don't create new resource #985

Merged
merged 1 commit into from
Jan 7, 2024
Merged

feat: if updated sts/rs equal current sts/rs, don't create new resource #985

merged 1 commit into from
Jan 7, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jan 7, 2024

No description provided.

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e72e717) 78.31% compared to head (c4ffd62) 78.30%.

Files Patch % Lines
controllers/apps/v2beta1/add_emqx_core.go 84.00% 3 Missing and 1 partial ⚠️
controllers/apps/v2beta1/add_emqx_repl.go 84.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
- Coverage   78.31%   78.30%   -0.02%     
==========================================
  Files          67       67              
  Lines        6060     6056       -4     
==========================================
- Hits         4746     4742       -4     
  Misses       1097     1097              
  Partials      217      217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit f5bbddd into emqx:main Jan 7, 2024
37 of 38 checks passed
@Rory-Z Rory-Z deleted the support-revert-resource branch January 7, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant